AndorsTrailRelease/archived-ATCS
1
0
Fork 0
mirror of https://github.com/AndorsTrailRelease/ATCS.git synced 2025-10-27 18:44:03 +01:00
Code Issues 1 Packages Projects Releases 5 Wiki Activity

[PR #4] [MERGED] Ignore empty sprites in SpriteChooser #5

New Issue
Closed
opened 2025-10-27 18:43:44 +01:00 by OMGeeky · 0 comments
OMGeeky commented 2025-10-27 18:43:44 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/AndorsTrailRelease/ATCS/pull/4
Author: @OMGeeky
Created: 9/10/2023
Status: ✅ Merged
Merged: 9/10/2023
Merged by: @NutAndor

Base: master ← Head: ignore_empty_sprites_in_chooser

📝 Commits (2)

  • fc0d97a reformat file & optimize usings
  • ada352a implement ignoring fully transparent sprites

📊 Changes

2 files changed (+78 additions, -51 deletions)

View changed files

📝 src/com/gpl/rpg/atcontentstudio/ui/sprites/SpriteChooser.java (+44 -51)
➕ src/com/gpl/rpg/atcontentstudio/utils/SpriteUtils.java (+34 -0)

📄 Description

This just ignores all the empty sprites in the chooser, to not clutter the UI.

One potential problem might be that it is now impossible to choose a transparent tile. Imo we can ignore this since it does not crash when a transparent sprite is used, we just can't select it from ATCS. If that edgecase is needed then manually editing the file to select the right sprite would be the only way to do it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AndorsTrailRelease/ATCS/pull/4 **Author:** [@OMGeeky](https://github.com/OMGeeky) **Created:** 9/10/2023 **Status:** ✅ Merged **Merged:** 9/10/2023 **Merged by:** [@NutAndor](https://github.com/NutAndor) **Base:** `master` ← **Head:** `ignore_empty_sprites_in_chooser` --- ### 📝 Commits (2) - [`fc0d97a`](https://github.com/AndorsTrailRelease/ATCS/commit/fc0d97aa2fd2c0d1b76ff140d79ccb7f206633ab) reformat file & optimize usings - [`ada352a`](https://github.com/AndorsTrailRelease/ATCS/commit/ada352a02ca8917fb31946d304840af3db85fa94) implement ignoring fully transparent sprites ### 📊 Changes **2 files changed** (+78 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `src/com/gpl/rpg/atcontentstudio/ui/sprites/SpriteChooser.java` (+44 -51) ➕ `src/com/gpl/rpg/atcontentstudio/utils/SpriteUtils.java` (+34 -0) </details> ### 📄 Description This just ignores all the empty sprites in the chooser, to not clutter the UI. One potential problem might be that it is now impossible to choose a transparent tile. Imo we can ignore this since it does not crash when a transparent sprite is used, we just can't select it from ATCS. If that edgecase is needed then manually editing the file to select the right sprite would be the only way to do it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OMGeeky added the
pull-request
 label 2025-10-27 18:43:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OMGeeky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: AndorsTrailRelease/archived-ATCS#5
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?