[PR #6] [MERGED] add description field to actor conditions #8

New Issue

OMGeeky · 2025-10-27T18:43:45+01:00

OMGeeky commented

2025-10-27 18:43:45 +01:00

📋 Pull Request Information

Original PR: https://github.com/AndorsTrailRelease/ATCS/pull/6
Author: @OMGeeky
Created: 12/27/2024
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @NutAndor

Base: master ← Head: actor-condition-description

📝 Commits (1)

38a3ad8 add description field to actor conditions

📊 Changes

3 files changed (+12 additions, -1 deletions)

View changed files

📝 src/com/gpl/rpg/atcontentstudio/model/gamedata/ActorCondition.java (+5 -1)
📝 src/com/gpl/rpg/atcontentstudio/model/tools/i18n/PotGenerator.java (+1 -0)
📝 src/com/gpl/rpg/atcontentstudio/ui/gamedataeditors/ActorConditionEditor.java (+6 -0)

📄 Description

@NutAndor please test, if the potc still works as expected. I noticed that there was something done there for condition names, and I added the descriptions there as well, but I have no Idea, if that was the correct way to do it and don't know how to test it. I might need to add something, to ignore empty descriptions or something, but I'm not too sure (also don't know what would then happen if someone would delete a description)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AndorsTrailRelease/ATCS/pull/6 **Author:** [@OMGeeky](https://github.com/OMGeeky) **Created:** 12/27/2024 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@NutAndor](https://github.com/NutAndor) **Base:** `master` ← **Head:** `actor-condition-description` --- ### 📝 Commits (1) - [`38a3ad8`](https://github.com/AndorsTrailRelease/ATCS/commit/38a3ad85c84dd4c61051f7b41c5be469add6cde4) add description field to actor conditions ### 📊 Changes **3 files changed** (+12 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/com/gpl/rpg/atcontentstudio/model/gamedata/ActorCondition.java` (+5 -1) 📝 `src/com/gpl/rpg/atcontentstudio/model/tools/i18n/PotGenerator.java` (+1 -0) 📝 `src/com/gpl/rpg/atcontentstudio/ui/gamedataeditors/ActorConditionEditor.java` (+6 -0) </details> ### 📄 Description @NutAndor please test, if the potc still works as expected. I noticed that there was something done there for condition names, and I added the descriptions there as well, but I have no Idea, if that was the correct way to do it and don't know how to test it. I might need to add something, to ignore empty descriptions or something, but I'm not too sure (also don't know what would then happen if someone would delete a description) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OMGeeky added the

pull-request

label 2025-10-27 18:43:45 +01:00

OMGeeky referenced this issue

2025-10-27 18:43:45 +01:00

[PR #8] [MERGED] Auto-Package on release #9

OMGeeky closed this issue

2025-10-27 18:43:45 +01:00

Sign in to join this conversation.