refactor: simplify link method by extracting parsing/linking logic

src/com/gpl/rpg/atcontentstudio/model/GameDataElement.java

@@ -189,5 +189,31 @@ public abstract class GameDataElement implements ProjectTreeNode, Serializable {
 	public abstract void save();
 
 	public abstract List<SaveEvent> attemptSave();
-	
+
+	/**
+	 * Checks if the current state indicates that parsing/linking should be skipped.
+	 * @return true if the operation should be skipped, false otherwise
+	 */
+	protected boolean shouldSkipParseOrLink() {
+		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+			//This type of state is unrelated to parsing/linking.
+			return true;
+		}
+		if (this.state == State.linked) {
+			//Already linked.
+			return true;
+		}
+		return false;
+	}
+
+	/**
+	 * Ensures the element is parsed if needed based on its current state.
+	 */
+	protected void ensureParseIfNeeded() {
+		if (this.state == State.init) {
+			//Not parsed yet.
+			this.parse();
+		}
+	}
+
 }

src/com/gpl/rpg/atcontentstudio/model/gamedata/ActorCondition.java

@@ -224,17 +224,10 @@ public class ActorCondition extends JSONElement {
 
 	@Override
 	public void link() {
-		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+		if (shouldSkipParseOrLink()) {
-			//This type of state is unrelated to parsing/linking.
-			return;
-		}
-		if (this.state == State.init) {
-			//Not parsed yet.
-			this.parse();
-		} else if (this.state == State.linked) {
-			//Already linked.
 			return;
 		}
+		ensureParseIfNeeded();
 		if (this.icon_id != null) {
 			String spritesheetId = this.icon_id.split(":")[0];
 			if (getProject().getSpritesheet(spritesheetId) == null) {

src/com/gpl/rpg/atcontentstudio/model/gamedata/Dialogue.java

@@ -206,17 +206,10 @@ public class Dialogue extends JSONElement {
 
 	@Override
 	public void link() {
-		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+		if (shouldSkipParseOrLink()) {
-			//This type of state is unrelated to parsing/linking.
-			return;
-		}
-		if (this.state == State.init) {
-			//Not parsed yet.
-			this.parse();
-		} else if (this.state == State.linked) {
-			//Already linked.
 			return;
 		}
+		ensureParseIfNeeded();
 		Project proj = getProject();
 		if (proj == null) {
 			Notification.addError("Error linking dialogue "+id+". No parent project found.");

src/com/gpl/rpg/atcontentstudio/model/gamedata/Droplist.java

@@ -129,17 +129,10 @@ public class Droplist extends JSONElement {
 
 	@Override
 	public void link() {
-		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+		if (shouldSkipParseOrLink()) {
-			//This type of state is unrelated to parsing/linking.
-			return;
-		}
-		if (this.state == State.init) {
-			//Not parsed yet.
-			this.parse();
-		} else if (this.state == State.linked) {
-			//Already linked.
 			return;
 		}
+		ensureParseIfNeeded();
 		Project proj = getProject();
 		if (proj == null) {
 			Notification.addError("Error linking droplist "+id+". No parent project found.");

src/com/gpl/rpg/atcontentstudio/model/gamedata/Item.java

@@ -206,17 +206,10 @@ public class Item extends JSONElement {
 
 	@Override
 	public void link() {
-		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+		if (shouldSkipParseOrLink()) {
-			//This type of state is unrelated to parsing/linking.
-			return;
-		}
-		if (this.state == State.init) {
-			//Not parsed yet.
-			this.parse();
-		} else if (this.state == State.linked) {
-			//Already linked.
 			return;
 		}
+		ensureParseIfNeeded();
 		Project proj = getProject();
 		if (proj == null) {
 			Notification.addError("Error linking item "+id+". No parent project found.");

src/com/gpl/rpg/atcontentstudio/model/gamedata/ItemCategory.java

@@ -171,18 +171,11 @@ public class ItemCategory extends JSONElement {
 
 	@Override
 	public void link() {
-		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+		if (shouldSkipParseOrLink()) {
-			//This type of state is unrelated to parsing/linking.
 			return;
 		}
-		if (this.state == State.init) {
+		ensureParseIfNeeded();
-			//Not parsed yet.
+
-			this.parse();
-		} else if (this.state == State.linked) {
-			//Already linked.
-			return;
-		}
-		
 		//Nothing to link to :D
 		this.state = State.linked;
 	}

src/com/gpl/rpg/atcontentstudio/model/gamedata/JSONElement.java

@@ -26,8 +26,7 @@ public abstract class JSONElement extends GameDataElement {
 
 	@SuppressWarnings("rawtypes")
 	public void parse() {
-		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+		if (shouldSkipParseOrLink()) {
-			//This type of state is unrelated to parsing/linking.
 			return;
 		}
 		JSONParser parser = new JSONParser();

src/com/gpl/rpg/atcontentstudio/model/gamedata/NPC.java

@@ -208,17 +208,10 @@ public class NPC extends JSONElement {
 
 	@Override
 	public void link() {
-		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+		if (shouldSkipParseOrLink()) {
-			//This type of state is unrelated to parsing/linking.
-			return;
-		}
-		if (this.state == State.init) {
-			//Not parsed yet.
-			this.parse();
-		} else if (this.state == State.linked) {
-			//Already linked.
 			return;
 		}
+		ensureParseIfNeeded();
 		Project proj = getProject();
 		if (proj == null) {
 			Notification.addError("Error linking item "+id+". No parent project found.");

src/com/gpl/rpg/atcontentstudio/model/gamedata/Quest.java

@@ -113,18 +113,11 @@ public class Quest extends JSONElement {
 
 	@Override
 	public void link() {
-		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+		if (shouldSkipParseOrLink()) {
-			//This type of state is unrelated to parsing/linking.
 			return;
 		}
-		if (this.state == State.init) {
+		ensureParseIfNeeded();
-			//Not parsed yet.
+
-			this.parse();
-		} else if (this.state == State.linked) {
-			//Already linked.
-			return;
-		}
-		
 		for (QuestStage stage : stages) {
 			stage.link();
 		}

src/com/gpl/rpg/atcontentstudio/model/gamedata/QuestStage.java

@@ -59,18 +59,11 @@ public class QuestStage extends JSONElement {
 
 	@Override
 	public void link() {
-		if (this.state == State.created || this.state == State.modified || this.state == State.saved) {
+		if (shouldSkipParseOrLink()) {
-			//This type of state is unrelated to parsing/linking.
 			return;
 		}
-		if (this.state == State.init) {
+		ensureParseIfNeeded();
-			//Not parsed yet.
+
-			this.parse();
-		} else if (this.state == State.linked) {
-			//Already linked.
-			return;
-		}
-		
 		//Nothing to link to :D
 		this.state = State.linked;
 	}