Fixed many bugs in the TMX Maps management. Added the

removeQuestProgress dialogue reward type. Initiallized the GDEVisitor
class to help with finding dependencies (through the Beanshell console
only for now).

src/com/gpl/rpg/atcontentstudio/model/gamedata/Dialogue.java

@@ -54,6 +54,7 @@ public class Dialogue extends JSONElement {
 		
 		public enum RewardType {
 			questProgress,
+			removeQuestProgress,
 			dropList,
 			skillIncrease,
 			actorCondition,
@@ -264,6 +265,7 @@ public class Dialogue extends JSONElement {
 						reward.reward_obj = proj.getItem(reward.reward_obj_id);
 						break;
 					case questProgress:
+					case removeQuestProgress:
 						reward.reward_obj = proj.getQuest(reward.reward_obj_id);
 						if (reward.reward_obj != null && reward.reward_value != null) {
 							QuestStage stage = ((Quest)reward.reward_obj).getStage(reward.reward_value);

src/com/gpl/rpg/atcontentstudio/model/maps/ReplaceArea.java

@@ -12,7 +12,7 @@ import com.gpl.rpg.atcontentstudio.ui.DefaultIcons;
 public class ReplaceArea extends MapObject {
 
 	public Requirement requirement = null;
-	public boolean oldSchoolRequirement = true;
+	public boolean oldSchoolRequirement = false;
 	
 	public List<ReplaceArea.Replacement> replacements = null;
 
@@ -26,14 +26,12 @@ public class ReplaceArea extends MapObject {
 //				requireType = Requirement.RequirementType.questProgress.toString();
 				requireValue = fields[1];
 				requireId = fields[0];
+				oldSchoolRequirement = true;
 			} /*else if (fields.length == 3) {
 				requireValue = fields[2];
 				requireType = fields[0];
 				requireId = fields[1];
 			}*/
-			oldSchoolRequirement = true;
-		} else {
-			oldSchoolRequirement = false;
 		}
 		requirement = new Requirement();
 		//Replace areas only support questProgress requirements ATM
@@ -45,6 +43,7 @@ public class ReplaceArea extends MapObject {
 		
 		
 		for (Object s : obj.getProperties().keySet()) {
+			if (!TMXMap.isPaintedLayerName(s.toString())) continue;
 			if (replacements == null) replacements = new ArrayList<ReplaceArea.Replacement>();
 			replacements.add(new Replacement(s.toString(), obj.getProperties().getProperty(s.toString())));
 		}

src/com/gpl/rpg/atcontentstudio/model/maps/TMXMap.java

@@ -273,11 +273,12 @@ public class TMXMap extends GameDataElement {
 
 	public void save() {
 		if (writable) {
+			String xml = toXml();
 			try {
 				//TODO: check in fileutils, to test the workspace's filesystem once at startup, and figure out how many of these can occur, instead of hard-coded '2'
 				dismissNextChangeNotif += 2;
 				FileWriter w = new FileWriter(tmxFile);
-				w.write(toXml());
+				w.write(xml);
 				w.close();
 				this.state = State.saved;
 				changedOnDisk = false;

src/com/gpl/rpg/atcontentstudio/ui/gamedataeditors/DialogueEditor.java

@@ -417,6 +417,7 @@ public class DialogueEditor extends JSONElementEditor {
 				rewardObj = addItemBox(pane, ((Dialogue)target).getProject(), "Item: ", (Item) reward.reward_obj, writable, listener);
 				rewardValue = addIntegerField(pane, "Quantity: ", reward.reward_value, false, writable, listener);
 				break;
+			case removeQuestProgress:
 			case questProgress:
 				rewardMap = null;
 				rewardObjId = null;
@@ -826,6 +827,10 @@ public class DialogueEditor extends JSONElementEditor {
 				label.setText("Give quest progress "+rewardObjDesc+":"+reward.reward_value);
 				if (reward.reward_obj != null) label.setIcon(new ImageIcon(reward.reward_obj.getIcon()));
 				break;
+			case removeQuestProgress:
+				label.setText("Removes quest progress "+rewardObjDesc+":"+reward.reward_value);
+				if (reward.reward_obj != null) label.setIcon(new ImageIcon(reward.reward_obj.getIcon()));
+				break;
 			case removeSpawnArea:
 				label.setText("Remove all monsters in spawnarea area "+rewardObjDesc+" on map "+reward.map_name);
 				label.setIcon(new ImageIcon(DefaultIcons.getNPCIcon()));

src/com/gpl/rpg/atcontentstudio/ui/map/TMXMapEditor.java

@@ -260,7 +260,12 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 		addTileLayer.addActionListener(new ActionListener() {
 			@Override
 			public void actionPerformed(ActionEvent e) {
-				layerListModel.addObject(new tiled.core.TileLayer());
+				tiled.core.TileLayer layer = new tiled.core.TileLayer(map.tmxMap.getWidth(), map.tmxMap.getHeight());
+				layerListModel.addObject(layer);
+				map.state = GameDataElement.State.modified;
+				map.childrenChanged(new ArrayList<ProjectTreeNode>());
+				ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+				targetUpdated();
 			}
 		});
 		addObjectGroup = new JButton(new ImageIcon(DefaultIcons.getCreateObjectGroupIcon()));
@@ -270,6 +275,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 			@Override
 			public void actionPerformed(ActionEvent e) {
 				layerListModel.addObject(new tiled.core.ObjectGroup());
+				map.state = GameDataElement.State.modified;
+				map.childrenChanged(new ArrayList<ProjectTreeNode>());
+				ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+				targetUpdated();
 			}
 		});
 		deleteLayer = new JButton(new ImageIcon(DefaultIcons.getNullifyIcon()));
@@ -279,6 +288,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 			@Override
 			public void actionPerformed(ActionEvent e) {
 				layerListModel.removeObject(selectedLayer);
+				map.state = GameDataElement.State.modified;
+				map.childrenChanged(new ArrayList<ProjectTreeNode>());
+				ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+				targetUpdated();
 			}
 		});
 		JPanel layersButtonsPane = new JPanel();
@@ -363,6 +376,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 				@Override
 				public void actionPerformed(ActionEvent e) {
 					groupObjectsListModel.addObject(MapObject.newMapchange(new tiled.core.MapObject(0, 0, 32, 32), map));
+					map.state = GameDataElement.State.modified;
+					map.childrenChanged(new ArrayList<ProjectTreeNode>());
+					ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+					targetUpdated();
 				}
 			});
 			addSpawn = new JButton(new ImageIcon(DefaultIcons.getCreateSpawnareaIcon()));
@@ -372,6 +389,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 				@Override
 				public void actionPerformed(ActionEvent e) {
 					groupObjectsListModel.addObject(MapObject.newSpawnArea(new tiled.core.MapObject(0, 0, 32, 32), map));
+					map.state = GameDataElement.State.modified;
+					map.childrenChanged(new ArrayList<ProjectTreeNode>());
+					ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+					targetUpdated();
 				}
 			});
 			addRest = new JButton(new ImageIcon(DefaultIcons.getCreateRestIcon()));
@@ -381,6 +402,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 				@Override
 				public void actionPerformed(ActionEvent e) {
 					groupObjectsListModel.addObject(MapObject.newRest(new tiled.core.MapObject(0, 0, 32, 32), map));
+					map.state = GameDataElement.State.modified;
+					map.childrenChanged(new ArrayList<ProjectTreeNode>());
+					ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+					targetUpdated();
 				}
 			});
 			addKey = new JButton(new ImageIcon(DefaultIcons.getCreateKeyIcon()));
@@ -390,6 +415,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 				@Override
 				public void actionPerformed(ActionEvent e) {
 					groupObjectsListModel.addObject(MapObject.newKey(new tiled.core.MapObject(0, 0, 32, 32), map));
+					map.state = GameDataElement.State.modified;
+					map.childrenChanged(new ArrayList<ProjectTreeNode>());
+					ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+					targetUpdated();
 				}
 			});
 			addReplace = new JButton(new ImageIcon(DefaultIcons.getCreateReplaceIcon()));
@@ -399,6 +428,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 				@Override
 				public void actionPerformed(ActionEvent e) {
 					groupObjectsListModel.addObject(MapObject.newReplace(new tiled.core.MapObject(0, 0, 32, 32), map));
+					map.state = GameDataElement.State.modified;
+					map.childrenChanged(new ArrayList<ProjectTreeNode>());
+					ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+					targetUpdated();
 				}
 			});
 			addScript = new JButton(new ImageIcon(DefaultIcons.getCreateScriptIcon()));
@@ -408,6 +441,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 				@Override
 				public void actionPerformed(ActionEvent e) {
 					groupObjectsListModel.addObject(MapObject.newScript(new tiled.core.MapObject(0, 0, 32, 32), map));
+					map.state = GameDataElement.State.modified;
+					map.childrenChanged(new ArrayList<ProjectTreeNode>());
+					ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+					targetUpdated();
 				}
 			});
 			addContainer = new JButton(new ImageIcon(DefaultIcons.getCreateContainerIcon()));
@@ -417,6 +454,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 				@Override
 				public void actionPerformed(ActionEvent e) {
 					groupObjectsListModel.addObject(MapObject.newContainer(new tiled.core.MapObject(0, 0, 32, 32), map));
+					map.state = GameDataElement.State.modified;
+					map.childrenChanged(new ArrayList<ProjectTreeNode>());
+					ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+					targetUpdated();
 				}
 			});
 			addSign = new JButton(new ImageIcon(DefaultIcons.getCreateSignIcon()));
@@ -426,6 +467,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 				@Override
 				public void actionPerformed(ActionEvent e) {
 					groupObjectsListModel.addObject(MapObject.newSign(new tiled.core.MapObject(0, 0, 32, 32), map));
+					map.state = GameDataElement.State.modified;
+					map.childrenChanged(new ArrayList<ProjectTreeNode>());
+					ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+					targetUpdated();
 				}
 			});
 			deleteObject = new JButton(new ImageIcon(DefaultIcons.getNullifyIcon()));
@@ -435,6 +480,10 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 				@Override
 				public void actionPerformed(ActionEvent e) {
 					groupObjectsListModel.removeObject(selectedMapObject);
+					map.state = GameDataElement.State.modified;
+					map.childrenChanged(new ArrayList<ProjectTreeNode>());
+					ATContentStudio.frame.editorChanged(TMXMapEditor.this);
+					targetUpdated();
 				}
 			});
 
@@ -514,6 +563,7 @@ public class TMXMapEditor extends Editor implements TMXMap.MapChangedOnDiskListe
 		} else if (selected instanceof ReplaceArea) {
 			//Replace areas only use questProgress requirements ATM
 			//requirementTypeCombo = addEnumValueBox(pane, "Requirement type: ", Requirement.RequirementType.values(), ((ReplaceArea)selected).requirement.type, ((TMXMap)target).writable, listener);
+			areaField = addTextField(pane, "Area ID: ", ((ReplaceArea)selected).name, ((TMXMap)target).writable, listener);
 			requirementParamsPane = new JPanel();
 			requirementParamsPane.setLayout(new JideBoxLayout(requirementParamsPane, JideBoxLayout.PAGE_AXIS, 6));
 			pane.add(requirementParamsPane, JideBoxLayout.FIX);

src/com/gpl/rpg/atcontentstudio/ui/tools/GDEVisitor.java

@@ -0,0 +1,223 @@
+package com.gpl.rpg.atcontentstudio.ui.tools;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import com.gpl.rpg.atcontentstudio.model.GameDataElement;
+import com.gpl.rpg.atcontentstudio.model.GameSource;
+import com.gpl.rpg.atcontentstudio.model.gamedata.ActorCondition;
+import com.gpl.rpg.atcontentstudio.model.gamedata.Dialogue;
+import com.gpl.rpg.atcontentstudio.model.gamedata.Droplist;
+import com.gpl.rpg.atcontentstudio.model.gamedata.Item;
+import com.gpl.rpg.atcontentstudio.model.gamedata.ItemCategory;
+import com.gpl.rpg.atcontentstudio.model.gamedata.NPC;
+import com.gpl.rpg.atcontentstudio.model.gamedata.Quest;
+import com.gpl.rpg.atcontentstudio.model.gamedata.Requirement;
+import com.gpl.rpg.atcontentstudio.model.maps.ContainerArea;
+import com.gpl.rpg.atcontentstudio.model.maps.KeyArea;
+import com.gpl.rpg.atcontentstudio.model.maps.MapChange;
+import com.gpl.rpg.atcontentstudio.model.maps.MapObject;
+import com.gpl.rpg.atcontentstudio.model.maps.MapObjectGroup;
+import com.gpl.rpg.atcontentstudio.model.maps.ReplaceArea;
+import com.gpl.rpg.atcontentstudio.model.maps.RestArea;
+import com.gpl.rpg.atcontentstudio.model.maps.ScriptArea;
+import com.gpl.rpg.atcontentstudio.model.maps.SignArea;
+import com.gpl.rpg.atcontentstudio.model.maps.SpawnArea;
+import com.gpl.rpg.atcontentstudio.model.maps.TMXMap;
+import com.gpl.rpg.atcontentstudio.model.sprites.Spritesheet;
+
+public class GDEVisitor {
+
+	public static List<GameDataElement> findDependencies(GameDataElement origin, boolean includeSource) {
+		List<GameDataElement> visited = new ArrayList<GameDataElement>();
+		visit(origin, visited, includeSource);
+		return visited;
+	}
+	
+	private static void visit(GameDataElement element, List<GameDataElement> visited, boolean includeSource) {
+		if (element == null) return;
+		if (visited.contains(element)) return;
+		if (!(includeSource || element.getDataType() != GameSource.Type.source)) return;
+		
+		visited.add(element);
+		element.link();
+		if (element instanceof ActorCondition) {
+			visitActorCondition((ActorCondition)element, visited, includeSource);
+		} else if (element instanceof Dialogue) {
+			visitDialogue((Dialogue)element, visited, includeSource);
+		} else if (element instanceof Droplist) {
+			visitDroplist((Droplist)element, visited, includeSource);
+		} else if (element instanceof Item) {
+			visitItem((Item)element, visited, includeSource);
+		} else if (element instanceof ItemCategory) {
+			visitItemCategory((ItemCategory)element, visited, includeSource);
+		} else if (element instanceof NPC) {
+			visitNPC((NPC)element, visited, includeSource);
+		} else if (element instanceof Quest) {
+			visitQuest((Quest)element, visited, includeSource);
+		} else if (element instanceof TMXMap) {
+			visitTMXMap((TMXMap)element, visited, includeSource);
+		} else if (element instanceof Spritesheet) {
+			visitSpritesheet((Spritesheet)element, visited, includeSource);
+		}
+		
+	}
+
+	private static void visitActorCondition(ActorCondition element, List<GameDataElement> visited, boolean includeSource) {
+		if (element.icon_id != null) visit(element.getProject().getSpritesheet(element.icon_id.split(":")[0]), visited, includeSource);
+
+		for (GameDataElement backlink : element.getBacklinks()) {
+			visit(backlink, visited, includeSource);
+		}
+	}
+
+	private static void visitDialogue(Dialogue element, List<GameDataElement> visited, boolean includeSource) {
+		visit(element.switch_to_npc, visited, includeSource);
+		if (element.replies != null) {
+			for (Dialogue.Reply reply : element.replies) {
+				visit(reply.next_phrase, visited, includeSource);
+				if (reply.requirements != null) {
+					for (Requirement req : reply.requirements) {
+						visit(req.required_obj, visited, includeSource);
+					}
+				}
+			}
+		}
+		if (element.rewards != null) {
+			for (Dialogue.Reward reward : element.rewards) {
+				visit(reward.reward_obj, visited, includeSource);
+				visit(reward.map, visited, includeSource);
+			}
+		}
+		
+		for (GameDataElement backlink : element.getBacklinks()) {
+			visit(backlink, visited, includeSource);
+		}
+	}
+
+	private static void visitDroplist(Droplist element, List<GameDataElement> visited, boolean includeSource) {
+		if (element.dropped_items != null) {
+			for (Droplist.DroppedItem droppedItem : element.dropped_items) {
+				visit(droppedItem.item, visited, includeSource);
+			}
+		}
+		
+		for (GameDataElement backlink : element.getBacklinks()) {
+			visit(backlink, visited, includeSource);
+		}
+	}
+
+	private static void visitItem(Item element, List<GameDataElement> visited, boolean includeSource) {
+		visit(element.category, visited, includeSource);
+		if (element.icon_id != null) visit(element.getProject().getSpritesheet(element.icon_id.split(":")[0]), visited, includeSource);
+		if (element.equip_effect != null && element.equip_effect.conditions != null) {
+			for (Item.ConditionEffect condEffect : element.equip_effect.conditions) {
+				visit(condEffect.condition, visited, includeSource);
+			}
+		}
+		if (element.hit_effect != null) { 
+			if (element.hit_effect.conditions_source != null) {
+				for (Item.ConditionEffect condEffect : element.hit_effect.conditions_source) {
+					visit(condEffect.condition, visited, includeSource);
+				}
+			}
+			if (element.hit_effect.conditions_target != null) {
+				for (Item.ConditionEffect condEffect : element.hit_effect.conditions_target) {
+					visit(condEffect.condition, visited, includeSource);
+				}
+			}
+		}
+		
+
+		for (GameDataElement backlink : element.getBacklinks()) {
+			visit(backlink, visited, includeSource);
+		}
+	}
+
+	private static void visitItemCategory(ItemCategory element, List<GameDataElement> visited, boolean includeSource) {
+		//Nothing to visit
+	}
+
+	private static void visitNPC(NPC element, List<GameDataElement> visited, boolean includeSource) {
+		visit(element.dialogue, visited, includeSource);
+		visit(element.droplist, visited, includeSource);
+		if (element.icon_id != null) visit(element.getProject().getSpritesheet(element.icon_id.split(":")[0]), visited, includeSource);
+		if (element.hit_effect != null) {
+			if (element.hit_effect.conditions_source != null) {
+				for (NPC.TimedConditionEffect condEffect : element.hit_effect.conditions_source) {
+					visit(condEffect.condition, visited, includeSource);
+				}
+			}
+			if (element.hit_effect.conditions_target != null) {
+				for (NPC.TimedConditionEffect condEffect : element.hit_effect.conditions_target) {
+					visit(condEffect.condition, visited, includeSource);
+				}
+			}
+		}
+		
+
+		for (GameDataElement backlink : element.getBacklinks()) {
+			visit(backlink, visited, includeSource);
+		}
+	}
+
+	private static void visitQuest(Quest element, List<GameDataElement> visited, boolean includeSource) {
+		//Nothing to visit
+		
+
+		for (GameDataElement backlink : element.getBacklinks()) {
+			visit(backlink, visited, includeSource);
+		}
+	}
+
+	private static void visitTMXMap(TMXMap element, List<GameDataElement> visited, boolean includeSource) {
+		// TODO Auto-generated method stub
+		if (element.groups != null) {
+			for (MapObjectGroup group : element.groups) {
+				if (group.mapObjects != null) {
+					for (MapObject obj : group.mapObjects) {
+						if (obj instanceof ContainerArea) {
+							visit(((ContainerArea)obj).droplist, visited, includeSource);
+						} else if (obj instanceof KeyArea) {
+							visit(((KeyArea)obj).dialogue, visited, includeSource);
+							if (((KeyArea)obj).requirement != null) {
+								visit(((KeyArea)obj).requirement.required_obj, visited, includeSource);
+							}
+						} else if (obj instanceof MapChange) {
+							visit(((MapChange)obj).map, visited, includeSource);
+						} else if (obj instanceof ReplaceArea) {
+							if (((ReplaceArea)obj).requirement != null) {
+								visit(((ReplaceArea)obj).requirement.required_obj, visited, includeSource);
+							}
+						} else if (obj instanceof RestArea) {
+							//Nothing to visit
+						} else if (obj instanceof ScriptArea) {
+							visit(((ScriptArea)obj).dialogue, visited, includeSource);
+						} else if (obj instanceof SignArea) {
+							visit(((SignArea)obj).dialogue, visited, includeSource);
+						} else if (obj instanceof SpawnArea) {
+							if (((SpawnArea)obj).spawnGroup != null) {
+								for (NPC npc : ((SpawnArea)obj).spawnGroup) {
+									visit(npc, visited, includeSource);
+								}
+							}
+						}
+					}
+				}
+			}
+		}
+		
+		for (GameDataElement backlink : element.getBacklinks()) {
+			visit(backlink, visited, includeSource);
+		}
+	}
+
+	private static void visitSpritesheet(Spritesheet element, List<GameDataElement> visited, boolean includeSource) {
+		//Nothing to visit
+		
+		//Not even the backlinks. Makes no sense.
+	}
+	
+	
+	
+}