From f81972e8c465a3a205bd58f2062d06c48258942d Mon Sep 17 00:00:00 2001 From: Yechan Bae Date: Sat, 27 Jun 2020 20:22:59 -0400 Subject: [PATCH 1/2] Informational advisory for rust-lang-nursery/failure#336 --- crates/failure/RUSTSEC-0000-0000.toml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 crates/failure/RUSTSEC-0000-0000.toml diff --git a/crates/failure/RUSTSEC-0000-0000.toml b/crates/failure/RUSTSEC-0000-0000.toml new file mode 100644 index 0000000..08d763c --- /dev/null +++ b/crates/failure/RUSTSEC-0000-0000.toml @@ -0,0 +1,20 @@ +[advisory] +id = "RUSTSEC-0000-0000" +package = "failure" +date = "2019-11-13" +informational = "unsound" +title = "__private_get_type_id__ can be overriden with safe Rust code" +url = "https://github.com/rust-lang-nursery/failure/issues/336" +keywords = ["unsound"] +description = """ +Safe Rust code can implement malfunctioning `__private_get_type_id__` and cause +type confusion when downcasting, which is an undefined behavior. + +Normal users of Failure library are not affected. +""" + +[affected] +functions = { "failure::Fail::__private_get_type_id__" = [">= 0.1.0"] } + +[versions] +patched = [] From 7ba77515fa7e9671f1aa4858ee20cd23d2fb6778 Mon Sep 17 00:00:00 2001 From: Yechan Bae Date: Fri, 14 Aug 2020 18:15:56 -0400 Subject: [PATCH 2/2] Apply PR feedback --- crates/failure/RUSTSEC-0000-0000.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/failure/RUSTSEC-0000-0000.toml b/crates/failure/RUSTSEC-0000-0000.toml index 08d763c..4fb31ed 100644 --- a/crates/failure/RUSTSEC-0000-0000.toml +++ b/crates/failure/RUSTSEC-0000-0000.toml @@ -3,14 +3,14 @@ id = "RUSTSEC-0000-0000" package = "failure" date = "2019-11-13" informational = "unsound" -title = "__private_get_type_id__ can be overriden with safe Rust code" +title = "Type confusion if __private_get_type_id__ is overriden" url = "https://github.com/rust-lang-nursery/failure/issues/336" keywords = ["unsound"] description = """ Safe Rust code can implement malfunctioning `__private_get_type_id__` and cause type confusion when downcasting, which is an undefined behavior. -Normal users of Failure library are not affected. +Users who derive `Fail` trait are not affected. """ [affected]