From 378e21259753c2d381b5b0e495d03d83a9b5917d Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 6 Nov 2023 12:48:19 +0000 Subject: [PATCH] Assigned RUSTSEC-2023-0069 to sudo-rs (#1816) Co-authored-by: Shnatsel --- .duplicate-id-guard | 2 +- ...TSEC-0000-0000.md => RUSTSEC-2023-0069.md} | 56 +++++++++---------- 2 files changed, 29 insertions(+), 29 deletions(-) rename crates/sudo-rs/{RUSTSEC-0000-0000.md => RUSTSEC-2023-0069.md} (96%) diff --git a/.duplicate-id-guard b/.duplicate-id-guard index 8cdd17b..dc852ed 100644 --- a/.duplicate-id-guard +++ b/.duplicate-id-guard @@ -1,3 +1,3 @@ This file causes merge conflicts if two ID assignment jobs run concurrently. This prevents duplicate ID assignment due to a race between those jobs. -222dcb79d2f0a5d8698976c3b5c7852a0f117dfa2d390cb46677ccb3e7e8705a - +64e360f186db21fe5c5b48f78a5cfd5ee8a96712224caf0e9d059485a5f7099e - diff --git a/crates/sudo-rs/RUSTSEC-0000-0000.md b/crates/sudo-rs/RUSTSEC-2023-0069.md similarity index 96% rename from crates/sudo-rs/RUSTSEC-0000-0000.md rename to crates/sudo-rs/RUSTSEC-2023-0069.md index bfae757..4f54c30 100644 --- a/crates/sudo-rs/RUSTSEC-0000-0000.md +++ b/crates/sudo-rs/RUSTSEC-2023-0069.md @@ -1,28 +1,28 @@ -```toml -[advisory] -id = "RUSTSEC-0000-0000" - -package = "sudo-rs" -date = "2023-11-01" -url = "https://github.com/advisories/GHSA-2r3c-m6v7-9354" -references = ["https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-42456"] -categories = ["file-disclosure"] -cvss = "CVSS:3.1/AV:L/AC:L/PR:H/UI:R/S:U/C:N/I:L/A:L" -keywords = ["directory traversal", "http"] -aliases = ["CVE-2023-42456", "GHSA-2r3c-m6v7-9354"] - -[versions] -patched = [">= 0.2.1"] -``` - -# sudo-rs: Path Traversal vulnerability - -## Impact -An issue was discovered where usernames containing the . and / characters could result in the corruption of specific files on the filesystem. As usernames are generally not limited by the characters they can contain, a username appearing to be a relative path can be constructed. For example we could add a user to the system containing the username ../../../../bin/cp. When logged in as a user with that name, that user could run sudo -K to clear their session record file. The session code then constructs the path to the session file by concatenating the username to the session file storage directory, resulting in a resolved path of /bin/cp. The code then clears that file, resulting in the cp binary effectively being removed from the system. - -An attacker needs to be able to login as a user with a constructed username. Given that such a username is unlikely to exist on an existing system, they will also need to be able to create the users with the constructed usernames. - -## Patches -The bug is fixed in version 0.2.1 of sudo-rs. Sudo-rs now uses the uid for the user instead of their username for determining the filename. Note that an upgrade to this version will result in existing session files being ignored and users will be forced to re-authenticate. It also fully eliminates any possibility of path traversal, given that uids are always integer values. - -The issue was corrected in commit `bfdbda22968e3de43fa8246cab1681cfd5d5493d`. \ No newline at end of file +```toml +[advisory] +id = "RUSTSEC-2023-0069" + +package = "sudo-rs" +date = "2023-11-01" +url = "https://github.com/advisories/GHSA-2r3c-m6v7-9354" +references = ["https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-42456"] +categories = ["file-disclosure"] +cvss = "CVSS:3.1/AV:L/AC:L/PR:H/UI:R/S:U/C:N/I:L/A:L" +keywords = ["directory traversal", "http"] +aliases = ["CVE-2023-42456", "GHSA-2r3c-m6v7-9354"] + +[versions] +patched = [">= 0.2.1"] +``` + +# sudo-rs: Path Traversal vulnerability + +## Impact +An issue was discovered where usernames containing the . and / characters could result in the corruption of specific files on the filesystem. As usernames are generally not limited by the characters they can contain, a username appearing to be a relative path can be constructed. For example we could add a user to the system containing the username ../../../../bin/cp. When logged in as a user with that name, that user could run sudo -K to clear their session record file. The session code then constructs the path to the session file by concatenating the username to the session file storage directory, resulting in a resolved path of /bin/cp. The code then clears that file, resulting in the cp binary effectively being removed from the system. + +An attacker needs to be able to login as a user with a constructed username. Given that such a username is unlikely to exist on an existing system, they will also need to be able to create the users with the constructed usernames. + +## Patches +The bug is fixed in version 0.2.1 of sudo-rs. Sudo-rs now uses the uid for the user instead of their username for determining the filename. Note that an upgrade to this version will result in existing session files being ignored and users will be forced to re-authenticate. It also fully eliminates any possibility of path traversal, given that uids are always integer values. + +The issue was corrected in commit `bfdbda22968e3de43fa8246cab1681cfd5d5493d`.