From 2b29694072a090a14d51331e468712e413098f01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Linus=20F=C3=A4rnstrand?= Date: Sun, 14 Feb 2021 12:09:55 +0100 Subject: [PATCH] Add advisory on nb-connect SocketAddr casting --- crates/nb-connect/RUSTSEC-0000-0000.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 crates/nb-connect/RUSTSEC-0000-0000.md diff --git a/crates/nb-connect/RUSTSEC-0000-0000.md b/crates/nb-connect/RUSTSEC-0000-0000.md new file mode 100644 index 0000000..092e66d --- /dev/null +++ b/crates/nb-connect/RUSTSEC-0000-0000.md @@ -0,0 +1,22 @@ +```toml +[advisory] +id = "RUSTSEC-0000-0000" +package = "nb-connect" +date = "2021-02-14" +url = "https://github.com/smol-rs/nb-connect/issues/1" +keywords = ["memory", "layout", "cast"] +informational = "unsound" + +[versions] +patched = [">= 1.0.3"] +``` + +# `nb-connect` invalidly assumes the memory layout of std::net::SocketAddr + +The [`nb-connect`](https://crates.io/crates/nb-connect) crate has assumed `std::net::SocketAddrV4` +and `std::net::SocketAddrV6` have the same memory layout as the system C representation +`sockaddr`. It has simply casted the pointers to convert the socket addresses to the +system representation. The standard library does not say anything about the memory +layout, and this will cause invalid memory access if the standard library +changes the implementation. No warnings or errors will be emitted once the +change happens.