From de7a809f3ea43f9a60bcca85e5298282ca0a45ce Mon Sep 17 00:00:00 2001
From: Jacob Rothstein <hi@jbr.me>
Date: Tue, 23 Jan 2024 19:13:27 -0800
Subject: [PATCH] Add advisories for trillium-http and trillium-client (#1864)

* Add GHSA-9f9p-cp3c-72jf

* add credit section
---
 crates/trillium-client/RUSTSEC-0000-0000.md | 40 ++++++++++++++++++++
 crates/trillium-http/RUSTSEC-0000-0000.md   | 41 +++++++++++++++++++++
 2 files changed, 81 insertions(+)
 create mode 100644 crates/trillium-client/RUSTSEC-0000-0000.md
 create mode 100644 crates/trillium-http/RUSTSEC-0000-0000.md

diff --git a/crates/trillium-client/RUSTSEC-0000-0000.md b/crates/trillium-client/RUSTSEC-0000-0000.md
new file mode 100644
index 0000000..13711b1
--- /dev/null
+++ b/crates/trillium-client/RUSTSEC-0000-0000.md
@@ -0,0 +1,40 @@
+```toml
+[advisory]
+id = "RUSTSEC-0000-0000"
+package = "trillium-client"
+date = "2024-01-23"
+url = "https://github.com/trillium-rs/trillium/security/advisories/GHSA-9f9p-cp3c-72jf"
+keywords = ["http", "request", "splitting"]
+aliases = ["GHSA-9f9p-cp3c-72jf"]
+
+[versions]
+patched = [">= 0.5.4"]
+unaffected = []
+
+[affected]
+```
+
+# Improper Neutralization of CRLF Sequences in HTTP Headers ('HTTP Request/Response Splitting')
+
+### Summary
+Insufficient validation of outbound header values may lead to request splitting or response splitting attacks in scenarios where attackers have sufficient control over outbound headers.
+
+### Details
+Outbound `trillium_http::HeaderValue` and `trillium_http::HeaderName` can be constructed infallibly and were not checked for illegal bytes when sending requests. Thus, if an attacker has sufficient control over header values (or names) in a request that they could inject `\r\n` sequences, they could get the client and server out of sync, and then pivot to gain control over other parts of requests or responses. (i.e. exfiltrating data from other requests, SSRF, etc.)
+
+### Patches
+
+#### trillium-client >= 0.5.4:
+* If any header name or header value is invalid in the client request headers, awaiting the client Conn returns an `Error::MalformedHeader` prior to any network access.
+
+### Workarounds
+
+trillium client applications should sanitize or validate untrusted input that is included in header values and header names. Carriage return, newline, and null characters are not allowed.
+
+### Impact
+
+This only affects use cases where attackers have control of outbound headers, and can insert "\r\n" sequences. Specifically, if untrusted and unvalidated input is inserted into header names or values.
+
+### Credit
+
+Discovered and reported by [@divergentdave](https://github.com/divergentdave)
diff --git a/crates/trillium-http/RUSTSEC-0000-0000.md b/crates/trillium-http/RUSTSEC-0000-0000.md
new file mode 100644
index 0000000..7357711
--- /dev/null
+++ b/crates/trillium-http/RUSTSEC-0000-0000.md
@@ -0,0 +1,41 @@
+```toml
+[advisory]
+id = "RUSTSEC-0000-0000"
+package = "trillium-http"
+date = "2024-01-23"
+url = "https://github.com/trillium-rs/trillium/security/advisories/GHSA-9f9p-cp3c-72jf"
+keywords = ["http", "request", "splitting"]
+aliases = ["GHSA-9f9p-cp3c-72jf"]
+
+[versions]
+patched = [">= 0.3.12"]
+unaffected = []
+
+[affected]
+```
+
+# Improper Neutralization of CRLF Sequences in HTTP Headers ('HTTP Request/Response Splitting')
+
+### Summary
+Insufficient validation of outbound header values may lead to request splitting or response splitting attacks in scenarios where attackers have sufficient control over outbound headers.
+
+### Details
+Outbound `trillium_http::HeaderValue` and `trillium_http::HeaderName` can be constructed infallibly and were not checked for illegal bytes when sending responses from the server. Thus, if an attacker has sufficient control over header values (or names) in an outbound response that they could inject `\r\n` sequences, they could get the client and server out of sync, and then pivot to gain control over other parts of requests or responses. (i.e. exfiltrating data from other requests, SSRF, etc.)
+
+### Patches
+
+#### trillium-http >= 0.3.12:
+* If a header name is invalid in server response headers, the specific header and any associated values are omitted from network transmission.
+* If a header value is invalid in server response headers, the individual header value is omitted from network transmission. Other headers values with the same header name will still be sent.
+
+### Workarounds
+
+trillium services should sanitize or validate untrusted input that is included in header values and header names. Carriage return, newline, and null characters are not allowed.
+
+### Impact
+
+This only affects use cases where attackers have control of outbound headers, and can insert "\r\n" sequences. Specifically, if untrusted and unvalidated input is inserted into header names or values.
+
+### Credit
+
+Discovered and reported by [@divergentdave](https://github.com/divergentdave)