From 315e34185aa6e5a993891fbbc38586e4c9a41861 Mon Sep 17 00:00:00 2001 From: OMGeeky Date: Sun, 25 Aug 2024 13:23:25 +0200 Subject: [PATCH] Only add the loot once to the killedMonsterBags without this, the loot might be added multiple times to the UI when showing what has been dropped, allowing the player to get more items than they should be allowed to --- .../com/gpl/rpg/AndorsTrail/controller/CombatController.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/AndorsTrail/app/src/main/java/com/gpl/rpg/AndorsTrail/controller/CombatController.java b/AndorsTrail/app/src/main/java/com/gpl/rpg/AndorsTrail/controller/CombatController.java index a6bef097d..227fb4f76 100644 --- a/AndorsTrail/app/src/main/java/com/gpl/rpg/AndorsTrail/controller/CombatController.java +++ b/AndorsTrail/app/src/main/java/com/gpl/rpg/AndorsTrail/controller/CombatController.java @@ -250,7 +250,8 @@ public final class CombatController implements VisualEffectCompletedCallback { if (!loot.hasItemsOrGold()) { world.model.currentMaps.map.removeGroundLoot(loot); } else if (world.model.uiSelections.isInCombat) { - killedMonsterBags.add(loot); + if(!killedMonsterBags.contains(loot)) + killedMonsterBags.add(loot); } combatActionListeners.onPlayerKilledMonster(killedMonster);