refactor(mbuild+lib): remove map!, better dlg call

* map! wasn't used.
* improved delegate calls, using `match` or `delegate.is_some()` to
  get the nicest looking, shortest-possible code
This commit is contained in:
Sebastian Thiel
2015-03-17 21:56:34 +01:00
parent b90a191688
commit 76827ff665
2 changed files with 7 additions and 24 deletions

View File

@@ -54,20 +54,6 @@ use cmn::{Hub, ReadSeek, Part, ResponseResult, RequestValue, NestedType, Delegat
// UTILITIES ###
// ############
/// This macro is advertised in the documentation, which is why we deliver it as well
#[macro_export]
macro_rules! map(
{ $($key:expr => $value:expr),+ } => {
{
let mut m = ::std::collections::HashMap::new();
$(
m.insert($key, $value);
)+
m
}
};
);
${lib.scope_enum()}

View File

@@ -592,8 +592,9 @@ else {
}
let auth_header = hyper::header::Authorization(token.unwrap().access_token);
% endif
if ${delegate}.is_some() {
${delegate_call}.pre_request("${m.id}");
match ${delegate} {
Some(ref mut d) => d.pre_request("${m.id}"),
None => {}
}
match ${client}.request(hyper::method::Method::Extension("${m.httpMethod}".to_string()), url.as_slice())
.header(hyper::header::UserAgent("google-api-rust-client/${cargo.build_version}".to_string()))
@@ -607,16 +608,12 @@ else {
.send() {
Err(err) => {
if ${delegate}.is_some() {
match ${delegate_call}.http_error(&err) {
oauth2::Retry::Abort => return cmn::Result::HttpError(err),
oauth2::Retry::After(d) => {
sleep(d);
continue;
}
if let oauth2::Retry::After(d) = ${delegate_call}.http_error(&err) {
sleep(d);
continue;
}
} else {
return cmn::Result::HttpError(err);
}
return cmn::Result::HttpError(err)
}
Ok(mut res) => {
if !res.status.is_success() {