From e3f3cf070d51bc52a14965aecdbdca8c2e45d711 Mon Sep 17 00:00:00 2001 From: OMGeeky Date: Sat, 7 Jun 2025 14:05:45 +0200 Subject: [PATCH] fix: comment out connection loss assumption in MQTT publish and subscribe methods --- src/esp_sensors/mqtt.py | 15 ++++----------- src/esp_sensors/mqtt_client.py | 2 +- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/esp_sensors/mqtt.py b/src/esp_sensors/mqtt.py index e8bda6e..54ab81b 100644 --- a/src/esp_sensors/mqtt.py +++ b/src/esp_sensors/mqtt.py @@ -138,7 +138,7 @@ class ESP32MQTTClient: return True except Exception as e: print(f"[ESP32MQTT] Failed to publish: {e}") - self.connected = False # Assume connection is lost on error + # self.connected = False # Assume connection is lost on error return False def subscribe(self, topic, qos=0): @@ -165,7 +165,7 @@ class ESP32MQTTClient: return True except Exception as e: print(f"[ESP32MQTT] Failed to subscribe: {e}") - self.connected = False # Assume connection is lost on error + # self.connected = False # Assume connection is lost on error return False def _message_callback(self, topic, msg): @@ -197,9 +197,7 @@ class ESP32MQTTClient: """ if not self.connected or not self.client: print("[ESP32MQTT] Not connected to broker") - # Try to reconnect - if not self.connect(): - return None + return None # Clear any previous message for this topic topic_str = ( @@ -230,12 +228,7 @@ class ESP32MQTTClient: time.sleep(0.1) except Exception as e: print(f"[ESP32MQTT] Error while reading topic: {e}") - self.connected = False - # Try to reconnect once - if self.connect(): - # Resubscribe to the topic - if self.subscribe(topic): - continue + # self.connected = False return None print( diff --git a/src/esp_sensors/mqtt_client.py b/src/esp_sensors/mqtt_client.py index a0ca731..b7032e2 100644 --- a/src/esp_sensors/mqtt_client.py +++ b/src/esp_sensors/mqtt_client.py @@ -263,7 +263,7 @@ class MQTTClient: return packet_type[0], b"" except Exception as e: - self.connected = False + # self.connected = False raise MQTTException(f"Failed to receive packet: {e}") def connect(self):