From 7580339415b66c8fc8b70c0209e2044b311fedae Mon Sep 17 00:00:00 2001 From: Benjamin Kirkbride Date: Sun, 19 Apr 2020 04:22:34 -0400 Subject: [PATCH] rf: use assertion in place of try/except to tell Mypy that something is This is the way that this should have been done all along. See: https://github.com/python/mypy/issues/5528 for a reference (though not the source) of this concept --- pytiled_parser/xml_parser.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pytiled_parser/xml_parser.py b/pytiled_parser/xml_parser.py index 4e6f57d..dfdfacf 100644 --- a/pytiled_parser/xml_parser.py +++ b/pytiled_parser/xml_parser.py @@ -245,10 +245,8 @@ def _parse_tile_layer(element: etree.Element,) -> objects.TileLayer: size = objects.Size(width, height) data_element = element.find("./data") - if data_element is not None: - data: objects.LayerData = _parse_data(data_element, width) - else: - raise ValueError(f"{element} has no child data element.") + assert data_element is not None + data: objects.LayerData = _parse_data(data_element, width) return objects.TileLayer( id_=id_,