From 200407a4c9d0b0c0a5929c1508749c41a9a36872 Mon Sep 17 00:00:00 2001 From: Tim Kuehn Date: Sun, 8 Jan 2017 17:30:31 -0800 Subject: [PATCH 1/3] Make connection backlog arg to listen a const --- src/server.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/server.rs b/src/server.rs index de2506e..7b0a722 100644 --- a/src/server.rs +++ b/src/server.rs @@ -60,13 +60,15 @@ pub fn listen_with(addr: SocketAddr, fn listener(addr: &SocketAddr, handle: &Handle) -> io::Result { + const PENDING_CONNECTION_BACKLOG = 1024; + match *addr { SocketAddr::V4(_) => net2::TcpBuilder::new_v4(), SocketAddr::V6(_) => net2::TcpBuilder::new_v6() }? .reuse_address(true)? .bind(addr)? - .listen(1024) + .listen(PENDING_CONNECTION_BACKLOG) .and_then(|l| { TcpListener::from_listener(l, addr, handle) }) From ef41d4349c7a8f9886422d83a13a33654d86c6d2 Mon Sep 17 00:00:00 2001 From: Tim Kuehn Date: Sun, 8 Jan 2017 17:34:44 -0800 Subject: [PATCH 2/3] Make connection backlog arg to listen a const --- src/server.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server.rs b/src/server.rs index 7b0a722..6f02464 100644 --- a/src/server.rs +++ b/src/server.rs @@ -60,7 +60,7 @@ pub fn listen_with(addr: SocketAddr, fn listener(addr: &SocketAddr, handle: &Handle) -> io::Result { - const PENDING_CONNECTION_BACKLOG = 1024; + const PENDING_CONNECTION_BACKLOG: i32 = 1024; match *addr { SocketAddr::V4(_) => net2::TcpBuilder::new_v4(), From 3719564efc71f9f3e881440c942d08d75a403362 Mon Sep 17 00:00:00 2001 From: Tim Kuehn Date: Sun, 8 Jan 2017 17:38:05 -0800 Subject: [PATCH 3/3] Fix stale comment --- src/framed.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/framed.rs b/src/framed.rs index 3437561..6791753 100644 --- a/src/framed.rs +++ b/src/framed.rs @@ -18,7 +18,7 @@ use util::{Debugger, Never}; pub type Frame = multiplex::Frame; -// `T` is the type that `Codec` parses. +// `Req` is the type that `Codec` parses. `Resp` is the type it serializes. pub struct Codec { state: CodecState, _phantom_data: PhantomData<(Req, Resp)>,