mirror of
https://github.com/OMGeeky/yup-oauth2.git
synced 2025-12-29 23:53:35 +01:00
88a8f74406
The current code uses standard blocking i/o operations (std::fs::*) this is problematic as it would block the entire futures executor waiting for i/o. This change is a major refactoring to make the token storage mechansim async i/o friendly. The first major decision was to abandon the GetToken trait. The trait is only implemented internally and there was no mechanism for users to provide their own, but async fn's are not currently supported in trait impls so keeping the trait would have required Boxing futures. This probably would have been fine, but seemed unnecessary. Instead of a trait the storage mechanism is just an enum with a choice between Memory and Disk storage. The DiskStorage works primarily as it did before, rewriting the entire contents of the file on every set() invocation. The only difference is that we now defer the actual writing to a separate task so that it does not block the return of the Token to the user. If disk i/o is too slow to keep up with the rate of incoming writes it will push back and will eventually block the return of tokens, this is to prevent a buildup of in-flight requests. One major drawback to this approach is that any errors that happen on write are simply logged and no delegate function is invoked on error because the delegate no longer has the ability to say to sleep, retry, etc.
