Merge branch 'master' of https://github.com/Zukero/ATCS.git

The full round effect's visual effect was not read from the correct
field, causing NPEs.

ATCS_JAR.jardesc

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="WINDOWS-1252" standalone="no"?>
 <jardesc>
-    <jar path="ATCS/ATCS_v0.6.7.jar"/>
-    <options buildIfNeeded="true" compress="true" descriptionLocation="/ATCS/ATCS_JAR.jardesc" exportErrors="true" exportWarnings="true" includeDirectoryEntries="false" overwrite="false" saveDescription="true" storeRefactorings="false" useSourceFolders="false"/>
+    <jar path="ATContentStudio/ATCS_v0.6.9.jar"/>
+    <options buildIfNeeded="true" compress="true" descriptionLocation="/ATContentStudio/ATCS_JAR.jardesc" exportErrors="true" exportWarnings="true" includeDirectoryEntries="false" overwrite="false" saveDescription="true" storeRefactorings="false" useSourceFolders="false"/>
     <storedRefactorings deprecationInfo="true" structuralOnly="false"/>
     <selectedProjects/>
     <manifest generateManifest="true" manifestLocation="" manifestVersion="1.0" reuseManifest="false" saveManifest="false" usesManifest="true">
@@ -11,9 +11,9 @@
         </sealing>
     </manifest>
     <selectedElements exportClassFiles="true" exportJavaFiles="true" exportOutputFolder="false">
-        <javaElement handleIdentifier="=ATCS/res"/>
-        <javaElement handleIdentifier="=ATCS/src"/>
-        <javaElement handleIdentifier="=ATCS/siphash-zackehh\/src\/main\/java"/>
-        <javaElement handleIdentifier="=ATCS/hacked-libtiled"/>
+        <javaElement handleIdentifier="=ATContentStudio/hacked-libtiled"/>
+        <javaElement handleIdentifier="=ATContentStudio/siphash-zackehh\/src\/main\/java"/>
+        <javaElement handleIdentifier="=ATContentStudio/src"/>
+        <javaElement handleIdentifier="=ATContentStudio/res"/>
     </selectedElements>
 </jardesc>

packaging/ATCS_latest

@@ -1 +1 @@
-v0.6.7
+v0.6.9

packaging/Windows/ATCS_Installer.nsi

@@ -1,6 +1,6 @@
 !include MUI2.nsh
 
-!define VERSION "0.6.8"
+!define VERSION "0.6.9"
 !define TRAINER_VERSION "0.1.4"
 !define JAVA_BIN "javaw"
 

src/com/gpl/rpg/atcontentstudio/ATContentStudio.java

@@ -43,7 +43,7 @@ import prefuse.data.expression.parser.ExpressionParser;
 public class ATContentStudio {
 
 	public static final String APP_NAME = "Andor's Trail Content Studio";
-	public static final String APP_VERSION = "v0.6.8";
+	public static final String APP_VERSION = "v0.6.9";
 	
 	public static final String CHECK_UPDATE_URL = "https://andorstrail.com/static/ATCS_latest";
 	public static final String DOWNLOAD_URL = "https://andorstrail.com/viewtopic.php?f=6&t=4806";

src/com/gpl/rpg/atcontentstudio/model/gamedata/ActorCondition.java

@@ -208,7 +208,7 @@ public class ActorCondition extends JSONElement {
 				this.full_round_effect.ap_boost_max = JSONElement.getInteger((Number) (((Map)fullRoundEffect.get("increaseCurrentAP")).get("max")));
 				this.full_round_effect.ap_boost_min = JSONElement.getInteger((Number) (((Map)fullRoundEffect.get("increaseCurrentAP")).get("min")));
 			}
-			String vfx = (String) roundEffect.get("visualEffectID");
+			String vfx = (String) fullRoundEffect.get("visualEffectID");
 			this.full_round_effect.visual_effect = null;
 			if (vfx != null) {
 				try {

src/com/gpl/rpg/atcontentstudio/model/maps/WorldmapSegment.java

@@ -23,6 +23,7 @@ import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 import org.w3c.dom.NodeList;
 
+import com.gpl.rpg.atcontentstudio.ATContentStudio;
 import com.gpl.rpg.atcontentstudio.model.GameDataElement;
 import com.gpl.rpg.atcontentstudio.model.ProjectTreeNode;
 import com.gpl.rpg.atcontentstudio.model.SaveEvent;
@@ -112,12 +113,20 @@ public class WorldmapSegment extends GameDataElement {
 				mapLocations.remove(oldOne.id);
 				modified = true;
 			}
+			List<String> deprecatedLabels = new ArrayList<String>();
 			for (String label : labelledMaps.keySet()) { 
 				if (labelledMaps.get(label).contains(oldOne.id)) {
 					labelledMaps.get(label).remove(oldOne.id);
 					modified = true;
+					if (labelledMaps.get(label).isEmpty()) {
+						deprecatedLabels.add(label);
+					}
 				}
 			}
+			for (String label : deprecatedLabels) {
+				labelledMaps.remove(label);
+				labels.remove(label);
+			}
 		}
 		
 		oldOne.removeBacklink(this);
@@ -126,6 +135,7 @@ public class WorldmapSegment extends GameDataElement {
 		if (modified) {
 			this.state = GameDataElement.State.modified;
 			childrenChanged(new ArrayList<ProjectTreeNode>());
+			ATContentStudio.frame.editorChanged(this);
 		}
 	}
 

src/com/gpl/rpg/atcontentstudio/ui/map/WorldMapView.java

@@ -23,7 +23,6 @@ import java.util.HashSet;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Set;
 import java.util.concurrent.CopyOnWriteArrayList;
 
 import javax.swing.JComponent;
@@ -191,7 +190,7 @@ public class WorldMapView extends JComponent implements Scrollable {
         FontMetrics mifm = g2.getFontMetrics();
         int mapIdLabelHeight = mifm.getHeight();
         
-        for (String s : mapLocations.keySet()) {
+        for (String s : new HashSet<String>(mapLocations.keySet())) {
 
         	int x = mapLocations.get(s).x;
         	int y = mapLocations.get(s).y;
@@ -481,6 +480,10 @@ public class WorldMapView extends JComponent implements Scrollable {
 		offsetX = worldmap.segmentX * TILE_SIZE;
 		offsetY = worldmap.segmentY * TILE_SIZE;
 		for (String s : worldmap.mapLocations.keySet()) {
+			if (proj.getMap(s) == null) {
+				System.err.println("Warning. Worldmap "+worldmap.id+" references map "+s+" but it doesn't exist in this project");
+				continue;
+			}
 			int x = worldmap.mapLocations.get(s).x * TILE_SIZE;
 			int w = proj.getMap(s).tmxMap.getWidth() * TILE_SIZE;
 			int y = worldmap.mapLocations.get(s).y * TILE_SIZE;
@@ -497,6 +500,10 @@ public class WorldMapView extends JComponent implements Scrollable {
 		worldmap.segmentX = offsetX / TILE_SIZE;
 		worldmap.segmentY = offsetY / TILE_SIZE;
 		for (String id : worldmap.mapLocations.keySet()) {
+			if (worldmap.getProject().getMap(id) == null) {
+				System.err.println("Warning. Worldmap "+worldmap.id+" references map "+id+" but it doesn't exist in this project");
+				continue;
+			}
 			worldmap.getProject().getMap(id).removeBacklink(worldmap);
 		}
 		worldmap.mapLocations.clear();
@@ -508,6 +515,10 @@ public class WorldMapView extends JComponent implements Scrollable {
 		}
 		
 		for (String id : worldmap.mapLocations.keySet()) {
+			if (worldmap.getProject().getMap(id) == null) {
+				System.err.println("Warning. Worldmap "+worldmap.id+" references map "+id+" but it doesn't exist in this project");
+				continue;
+			}
 			worldmap.getProject().getMap(id).addBacklink(worldmap);
 		}