AndorsTrailRelease/archived-ATCS
1
0
Fork 0
mirror of https://github.com/AndorsTrailRelease/ATCS.git synced 2025-10-27 18:44:03 +01:00
Code Issues 1 Packages Projects Releases 5 Wiki Activity

[PR #15] [MERGED] Miss effect #15

New Issue
Closed
opened 2025-10-27 18:43:46 +01:00 by OMGeeky · 0 comments
OMGeeky commented 2025-10-27 18:43:46 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/AndorsTrailRelease/ATCS/pull/15
Author: @OMGeeky
Created: 10/2/2025
Status: ✅ Merged
Merged: 10/3/2025
Merged by: @NutAndor

Base: master ← Head: miss-effect

📝 Commits (7)

  • 29241f1 improve EffectPane generics and usage & fix hitReceivedEffect
  • 806f0b1 miss effect
  • 3b99a94 add comments to start script about min required java version; update nsi script to match standalone start script
  • b2003bf improve create pane content calls with overrides
  • 7e5c8d0 improve hints on who is getting what effect on hit / hit-received for npcs
  • 31cbdca add clarification comment to package.sh
  • be040a7 change miss_effect to HitEffect instead of HitReceivedEffect

📊 Changes

8 files changed (+153 additions, -85 deletions)

View changed files

📝 packaging/Windows/ATCS_Installer.nsi (+4 -4)
📝 packaging/common/ATCS.cmd (+2 -0)
📝 packaging/common/ATCS.sh (+5 -3)
📝 packaging/package.sh (+2 -2)
📝 src/com/gpl/rpg/atcontentstudio/model/gamedata/Item.java (+36 -0)
📝 src/com/gpl/rpg/atcontentstudio/ui/gamedataeditors/CommonEditor.java (+38 -35)
📝 src/com/gpl/rpg/atcontentstudio/ui/gamedataeditors/ItemEditor.java (+59 -24)
📝 src/com/gpl/rpg/atcontentstudio/ui/gamedataeditors/NPCEditor.java (+7 -17)

📄 Description

  • added miss effect and miss received effect.
  • added some missed changed events
  • further improved ItemEditor to reduce overhead when creating HitPanes
  • added some hints in the panes to make it easier to know if the player or the npc is getting the effect
  • improved packaging stuff a bit
    • added some comments in the .cmd and .sh files about the minimum java version
    • aligned the .cmd in the nsi to the standalone version
    • changed the shebang (#!) in the .sh starting file to something that is available on a wider variety of systems

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AndorsTrailRelease/ATCS/pull/15 **Author:** [@OMGeeky](https://github.com/OMGeeky) **Created:** 10/2/2025 **Status:** ✅ Merged **Merged:** 10/3/2025 **Merged by:** [@NutAndor](https://github.com/NutAndor) **Base:** `master` ← **Head:** `miss-effect` --- ### 📝 Commits (7) - [`29241f1`](https://github.com/AndorsTrailRelease/ATCS/commit/29241f18b8a811a571cd7d62618bda374f98647d) improve EffectPane generics and usage & fix hitReceivedEffect - [`806f0b1`](https://github.com/AndorsTrailRelease/ATCS/commit/806f0b10e621b2ddab605573e987c0dc9f2687e8) miss effect - [`3b99a94`](https://github.com/AndorsTrailRelease/ATCS/commit/3b99a946540753adb5864ed1448bf0052269dc66) add comments to start script about min required java version; update nsi script to match standalone start script - [`b2003bf`](https://github.com/AndorsTrailRelease/ATCS/commit/b2003bfc38e2b9cd99b075d9503bd68d7d009050) improve create pane content calls with overrides - [`7e5c8d0`](https://github.com/AndorsTrailRelease/ATCS/commit/7e5c8d05ab42ec78bb2394f141d7154255174212) improve hints on who is getting what effect on hit / hit-received for npcs - [`31cbdca`](https://github.com/AndorsTrailRelease/ATCS/commit/31cbdcabab2a17994b11b2e3bc0008961a78dbd1) add clarification comment to package.sh - [`be040a7`](https://github.com/AndorsTrailRelease/ATCS/commit/be040a74bdf46e8e4e1b5e3f62ec035f9ea965a5) change miss_effect to HitEffect instead of HitReceivedEffect ### 📊 Changes **8 files changed** (+153 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `packaging/Windows/ATCS_Installer.nsi` (+4 -4) 📝 `packaging/common/ATCS.cmd` (+2 -0) 📝 `packaging/common/ATCS.sh` (+5 -3) 📝 `packaging/package.sh` (+2 -2) 📝 `src/com/gpl/rpg/atcontentstudio/model/gamedata/Item.java` (+36 -0) 📝 `src/com/gpl/rpg/atcontentstudio/ui/gamedataeditors/CommonEditor.java` (+38 -35) 📝 `src/com/gpl/rpg/atcontentstudio/ui/gamedataeditors/ItemEditor.java` (+59 -24) 📝 `src/com/gpl/rpg/atcontentstudio/ui/gamedataeditors/NPCEditor.java` (+7 -17) </details> ### 📄 Description - added miss effect and miss received effect. - added some missed changed events - further improved ItemEditor to reduce overhead when creating HitPanes - added some hints in the panes to make it easier to know if the player or the npc is getting the effect - improved packaging stuff a bit - added some comments in the .cmd and .sh files about the minimum java version - aligned the .cmd in the nsi to the standalone version - changed the shebang (#!) in the .sh starting file to something that is available on a wider variety of systems --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OMGeeky added the
pull-request
 label 2025-10-27 18:43:46 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OMGeeky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: AndorsTrailRelease/archived-ATCS#15
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?