refactor: remove isCollapsed parameter and handle collapsing logic in DialogueEditor

This commit is contained in:
OMGeeky
2025-06-16 10:17:30 +02:00
parent 9deac7047f
commit e10bcfe20f
2 changed files with 5 additions and 6 deletions

View File

@@ -244,7 +244,6 @@ public class DialogueEditor extends JSONElementEditor {
RepliesCellRenderer cellRenderer = new RepliesCellRenderer();
repliesListModel = new DialogueEditor.RepliesListModel(dialogue);
boolean isCollapsed = dialogue.replies == null || dialogue.replies.isEmpty();
boolean moveUpDownEnabled = true;
CallWithSingleArg<Dialogue.Reply> selectedReplyChanged = e -> {
selectedReply = e;
@@ -258,7 +257,6 @@ public class DialogueEditor extends JSONElementEditor {
title,
cellRenderer,
repliesListModel,
isCollapsed,
dialogue.writable,
moveUpDownEnabled,
selectedReplyChanged,
@@ -267,6 +265,11 @@ public class DialogueEditor extends JSONElementEditor {
listener,
Dialogue.Reply::new);
boolean isEmpty = dialogue.replies == null || dialogue.replies.isEmpty();
if (isEmpty) {
replies.collapse();
}
pane.add(replies, JideBoxLayout.FIX);
}

View File

@@ -21,7 +21,6 @@ public final class CommonEditor {
public static <E, S> CollapsiblePanel createListPanel(String title,
ListCellRenderer<? super E> cellRenderer,
AtListModel<E, S> listModel,
boolean isCollapsed,
boolean writable,
boolean moveUpDownEnabled,
CallWithSingleArg<E> selectedValueSetter,
@@ -107,9 +106,6 @@ public final class CommonEditor {
listButtonsPane.add(new JPanel(), JideBoxLayout.VARY);
replies.add(listButtonsPane, JideBoxLayout.FIX);
}
if (isCollapsed) {
replies.collapse();
}
repliesEditorPane.setLayout(new JideBoxLayout(repliesEditorPane, JideBoxLayout.PAGE_AXIS));
replies.add(repliesEditorPane, JideBoxLayout.FIX);
return replies;