Merge pull request #796 from ammaraskar/byte_struct

[patched] Add advisory for uninitialized memory drop in byte_struct
This commit is contained in:
Sergey "Shnatsel" Davidoff
2021-03-02 19:11:30 +01:00
committed by GitHub

View File

@@ -0,0 +1,24 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "byte_struct"
date = "2021-03-01"
url = "https://github.com/wwylele/byte-struct-rs/issues/1"
categories = ["memory-corruption"]
keywords = ["memory-safety"]
[versions]
patched = [">= 0.6.1"]
```
# Deserializing an array can drop uninitialized memory on panic
The `read_bytes_default_le` function for `[T; n]` arrays, used to deserialize
arrays of `T` from bytes created a `[T; n]` array with `std::mem::uninitialized`
and then called `T`'s deserialization method.
If `T`'s deserialization method panicked, the uninitialized memory could drop
invalid objects.
This flaw was corrected in `a535678` by removing the unsafe block and using
a `.map` function to deserialize each element of the array instead.