OMGeeky/advisory-db
1
0
Fork 0
mirror of https://github.com/OMGeeky/advisory-db.git synced 2026-02-23 15:38:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add advisory on nb-connect SocketAddr casting

Browse Source
This commit is contained in:
Linus Färnstrand
2021-02-14 12:09:55 +01:00
parent 0283f676ac
commit 2b29694072
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
crates/nb-connect/RUSTSEC-0000-0000.md Normal file
View File

@@ -0,0 +1,22 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "nb-connect"
date = "2021-02-14"
url = "https://github.com/smol-rs/nb-connect/issues/1"
keywords = ["memory", "layout", "cast"]
informational = "unsound"
[versions]
patched = [">= 1.0.3"]
```
# `nb-connect` invalidly assumes the memory layout of std::net::SocketAddr
The [`nb-connect`](https://crates.io/crates/nb-connect) crate has assumed `std::net::SocketAddrV4`
and `std::net::SocketAddrV6` have the same memory layout as the system C representation
`sockaddr`. It has simply casted the pointers to convert the socket addresses to the
system representation. The standard library does not say anything about the memory
layout, and this will cause invalid memory access if the standard library
changes the implementation. No warnings or errors will be emitted once the
change happens.