OMGeeky/advisory-db
1
0
Fork 0
mirror of https://github.com/OMGeeky/advisory-db.git synced 2025-12-30 16:24:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add soundness bug in secp256k1 API (#1480)

Browse Source 
* Add soundness bug in `secp256k1` API

Summary: Unsound API in `secp256k1` allows use-after-free and invalid
deallocation from safe code. This was fixed and backported to multiple
versions.

* Set `date` to the date of the original disclosure

Co-authored-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
This commit is contained in:
Martin Habovštiak
2022-12-07 23:28:57 +01:00
committed by GitHub
parent b80f8edaa7
commit 3be728db50
1 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
crates/secp256k1/RUSTSEC-0000-0000.md Normal file
View File

@@ -0,0 +1,36 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "secp256k1"
date = "2022-11-30"
url = "https://github.com/rust-bitcoin/rust-secp256k1/issues/543"
references = ["https://github.com/rust-bitcoin/rust-secp256k1/pull/548"]
informational = "unsound"
categories = ["memory-corruption"]
keywords = ["use-after-free", "unsound-api", "invalid-free"]
[affected]
functions = { "secp256k1::Secp256k1::preallocated_gen_new" = ["< 0.22.2", ">= 0.23.0, < 0.23.5", ">= 0.24.0, < 0.24.2"] }
[versions]
patched = [">= 0.22.2, < 0.23.0", ">= 0.23.5, < 0.24.0", ">= 0.24.2"]
unaffected = ["< 0.14.0"]
```
# Unsound API in `secp256k1` allows use-after-free and invalid deallocation from safe code
Because of incorrect bounds on method `Secp256k1::preallocated_gen_new` it was possible to cause use-after-free from safe consumer code. It was also possible to "free" memory not allocated by the appropriate allocator.
The method takes a place for storing the context as a mutable reference and returns context containing that reference. Because the code internally uses `unsafe` and the bounds were incorrect it was possible to create a context that outlived the passed reference (e.g. `'static`). Because the context can alternatively carry heap-allocated pointer freed on drop it was possible to "deallocate" a pointer that wasn't returned from appropriate allocator. The code decides whether to free the memory based on type parameter but because of missing bound it was possible to construct the context with invalid parameter.
You are unaffected if you either
* don't call `Secp256k1::preallocated_gen_new`
* manually checked that your usage of the method is sound
* upgraded to the patched version of `secp256k1` (recommended)
The patched version uses correct bounds which means it is API-breaking. This effectively means adopting the policy of Rust lang itself allowing API-breaking changes to fix soundness bugs. Note however that valid straigthforward usage of the code will continue to compile. Only unsound code or code that propagates the bound in custom generics will fail to compile. If the code is sound fixing the bounds should be sufficient to make the code compile.
See the [GitHub issue](https://github.com/rust-bitcoin/rust-secp256k1/issues/543) for example "exploit" code and further discussion.