Merge pull request #799 from ammaraskar/stack_dst

[patched] Add advisory for double-free in stack_dst
This commit is contained in:
Sergey "Shnatsel" Davidoff
2021-03-03 15:38:51 +01:00
committed by GitHub

View File

@@ -0,0 +1,26 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "stack_dst"
date = "2021-02-22"
url = "https://github.com/thepowersgang/stack_dst-rs/issues/5"
categories = ["memory-corruption"]
keywords = ["memory-safety", "double-free"]
[versions]
patched = [">= 0.6.1"]
[affected]
functions = { "stack_dst::StackA::push_cloned" = ["< 0.6.1"] }
```
# push_cloned can drop uninitialized memory or double free on panic
Affected versions of `stack_dst` used a `push_inner` function that increased
the internal length of the array and then called `val.clone()`.
If the `val.clone()` call panics, the stack could drop an already dropped
element or drop uninitialized memory.
This issue was fixed in `2a4d538` by increasing the length of the array after
elements are cloned.