OMGeeky/google-apis-rs
1
0
Fork 0
mirror of https://github.com/OMGeeky/google-apis-rs.git synced 2026-01-21 18:54:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make remove_json_null_values O(n) instead of O(n^2)

Browse Source
This commit is contained in:
philippeitis
2022-09-30 07:35:55 +00:00
committed by GitHub
parent c56cd0c01a
commit 276324ae09
1 changed files with 7 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
google-apis-common/src/lib.rs
View File

@@ -752,32 +752,14 @@ where
// TODO(ST): Allow sharing common code between program types
pub fn remove_json_null_values(value: &mut json::value::Value) {
match *value {
json::value::Value::Object(ref mut map) => {
let mut for_removal = Vec::new();
for (key, mut value) in map.iter_mut() {
if value.is_null() {
for_removal.push(key.clone());
} else {
remove_json_null_values(&mut value);
}
}
for key in &for_removal {
map.remove(key);
}
match value {
json::value::Value::Object(map) => {
map.retain(|_, value| !value.is_null());
map.values_mut().for_each(remove_json_null_values);
}
json::value::Value::Array(ref mut arr) => {
let mut i = 0;
while i < arr.len() {
if arr[i].is_null() {
arr.remove(i);
} else {
remove_json_null_values(&mut arr[i]);
i += 1;
}
}
json::value::Value::Array(arr) => {
arr.retain(|value| !value.is_null());
arr.iter_mut().for_each(remove_json_null_values);
}
_ => {}
}