Cargo clippy

examples/concurrency.rs

@@ -58,7 +58,7 @@ impl FutureService for Server {
             .spawn(futures::lazy(move || {
                 let mut vec: Vec<u8> = Vec::with_capacity(size as usize);
                 for i in 0..size {
-                    vec.push((i % 1 << 8) as u8);
+                    vec.push(((i % 2) << 8) as u8);
                 }
                 debug!("Server sending response no. {}", request_number);
                 futures::finished(vec)

examples/pubsub.rs

@@ -57,7 +57,7 @@ impl subscriber::FutureService for Subscriber {
 }
 
 impl Subscriber {
-    fn new(id: u32) -> SocketAddr {
+    fn listen(id: u32) -> SocketAddr {
         Subscriber { id: id }
             .listen("localhost:0".first_socket_addr(),
                     server::Options::default())
@@ -125,10 +125,10 @@ fn main() {
     let publisher_client =
         publisher::SyncClient::connect(publisher_addr, client::Options::default()).unwrap();
 
-    let subscriber1 = Subscriber::new(0);
+    let subscriber1 = Subscriber::listen(0);
     publisher_client.subscribe(0, subscriber1).unwrap();
 
-    let subscriber2 = Subscriber::new(1);
+    let subscriber2 = Subscriber::listen(1);
     publisher_client.subscribe(1, subscriber2).unwrap();
 
 

examples/throughput.rs

@@ -30,7 +30,7 @@ lazy_static! {
 fn gen_vec(size: usize) -> Vec<u8> {
     let mut vec: Vec<u8> = Vec::with_capacity(size);
     for i in 0..size {
-        vec.push((i % 1 << 8) as u8);
+        vec.push(((i % 2) << 8) as u8);
     }
     vec
 }
@@ -98,7 +98,7 @@ fn bench_tcp(target: u64) {
 
 fn main() {
     let _ = env_logger::init();
-    &*BUF; // to non-lazily initialize it.
+    let _ = *BUF; // to non-lazily initialize it.
     bench_tcp(256 << 20);
     bench_tarpc(256 << 20);
 }

src/client.rs

@@ -140,6 +140,7 @@ pub mod future {
               Resp: Deserialize + 'static,
               E: Deserialize + 'static,
     {
+        #[allow(unknown_lints, type_complexity)]
         inner:
             future::Either<
                 futures::Map<tokio_core::net::TcpStreamNew, MultiplexConnect<Req, Resp, E>>,

src/macros.rs

@@ -510,7 +510,7 @@ macro_rules! service {
                                 unimplemented;
                             ::std::thread::spawn(move || {
                                 let __tarpc_service_reply = SyncService::$fn_name(
-                                    &mut __tarpc_service.service, $($arg),*);
+                                    &__tarpc_service.service, $($arg),*);
                                 __tarpc_service_complete.complete(
                                     $crate::futures::IntoFuture::into_future(
                                         __tarpc_service_reply));