Remove no longer applicatble TODO's

This commit is contained in:
Lukas Winkler
2021-12-01 13:47:29 +01:00
parent c7793063e4
commit 39c712dfab
3 changed files with 1 additions and 3 deletions

View File

@@ -32,7 +32,7 @@ impl ApplicationDefaultCredentialsFlow {
C: hyper::client::connect::Connect + Clone + Send + Sync + 'static,
{
let scope = crate::helper::join(scopes, ",");
let token_uri = format!("{}?scopes={}", self.metadata_url, scope); // TODO: This feels jank, can it be done better?
let token_uri = format!("{}?scopes={}", self.metadata_url, scope);
let request = hyper::Request::get(token_uri)
.header("Metadata-Flavor", "Google")
.body(hyper::Body::from(String::new())) // why body is needed?

View File

@@ -257,7 +257,6 @@ impl ServiceAccountAuthenticator {
}
}
// TODO: Can those use statements be cleaned up?
/// Create an authenticator that uses a application default credentials.
/// ```
/// # #[cfg(any(feature = "hyper-rustls", feature = "hyper-tls"))]

View File

@@ -604,7 +604,6 @@ async fn test_default_application_credentials_from_metadata_server() {
let _ = env_logger::try_init();
let server = Server::run();
server.expect(
// TODO: this does not work.
Expectation::matching(all_of![
request::method_path("GET", "/token"),
request::query(url_decoded(all_of![contains((